Update travis and fix a test #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can set up travis-ci by following these directions: https://travis-ci.org/getting_started Basically, just need to sign in to travis-ci with github, give them some permissions over your repositories, and then flip a switch over there. |
|
I'm going to merge this in because it makes testing easier (I have it set up on my fork right now, until we get it set up here.) I will create a new issue to track setting up travis-ci. |
|
Not sure why you specify BeautifulSoup for Python 2.x . Don't you want to use BeautifulSoup4 as well? |
|
You are right. I was following the readme install instructions, but while they specify bs3 for python2, they really mean python 2.6 and newer, since bs4 is available in 2.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.