Skip to content
This repository has been archived by the owner on Mar 6, 2023. It is now read-only.

add ncm2 source support #63

Merged
merged 1 commit into from Jul 13, 2018
Merged

add ncm2 source support #63

merged 1 commit into from Jul 13, 2018

Conversation

fcying
Copy link
Contributor

@fcying fcying commented Jul 13, 2018

@jsfaint
Copy link
Owner

jsfaint commented Jul 13, 2018

I tested this PR, it works for me 👍
But there are several minor things:

  1. Please rename the file ncm2_gen_tags as ncm2_gtags, because this is only gtags completion.
  2. Please remove trailing space in ncm2_gen_tags.py line 30

Thanks for your contribution!

BTW: Should we remove ncm source now? or just keep it for compatible.

@fcying
Copy link
Contributor Author

fcying commented Jul 13, 2018

I think it can be remove now.....

The maintainer said:

PLEASE USE https://github.com/ncm2/ncm2 INSTEAD

@jsfaint
Copy link
Owner

jsfaint commented Jul 13, 2018

OK, please remove it with a new commit.
I'll modify the document later when I get some time.

A little question why do you add cwd=data['cwd'] for subprocess.Popen()?
I removed this line, the source still works.
Just curious, because I'm not familiar with python 😄

@fcying
Copy link
Contributor Author

fcying commented Jul 13, 2018

It will changes the global working dir to cwd before subprocess executing the child, may be it will effect the relative position for some files?
I just saw it add in deoplete source, so I add it too@_@

@jsfaint
Copy link
Owner

jsfaint commented Jul 13, 2018

gtags/global checks the database via environment variable GTAGSDBPATH, but not in the current working directory
So maybe we can remove it?

@fcying
Copy link
Contributor Author

fcying commented Jul 13, 2018

Ok, I remove it both ncm2 and deoplete source.

@jsfaint jsfaint merged commit 3f33344 into jsfaint:master Jul 13, 2018
@fcying fcying deleted the ncm2 branch July 13, 2018 08:48
@jsfaint
Copy link
Owner

jsfaint commented Jul 13, 2018

Merged, thanks for your contribution~

@butterflyfish
Copy link

if possible, please help add function parameter expansion support. appreciated.

@jsfaint
Copy link
Owner

jsfaint commented Jul 16, 2018

gtags is tag based only, it is impossible to add parameter expansion support...

@butterflyfish
Copy link

butterflyfish commented Jul 16, 2018

GNU global provide function prototype, that's why I think it's impossible. Like ncm2/ncm2-pyclang provide parameter expansion.

example:

global -x new_terminal
new_terminal      113 src/terminal.c   new_terminal(tea_t* tea, char* name, int ifd, int ofd, aio_recv_t aio_recv)

@jsfaint
Copy link
Owner

jsfaint commented Jul 16, 2018

Yes, but it is not for completion. I have no idea how to implement it.
The PR is appreciated.

@butterflyfish
Copy link

I'm not python programmer, no idea also. Welcome someone implement this fantastic feature.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants