Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello bar forces content below page. #1495

Closed
Betanu701 opened this issue Oct 17, 2019 · 2 comments
Closed

Hello bar forces content below page. #1495

Betanu701 opened this issue Oct 17, 2019 · 2 comments

Comments

@Betanu701
Copy link

‼️‼️‼️

Known issues (see README.md) will not be
addressed and most likely will be closed.

‼️‼️‼️

If you have content in the JS editor, more than 18 lines, content gets pushed below page where it is not accessible while "hello-bar" is open.
id="show-result" has a height of 100vh. With hello-bar open, the 100vh is below screen. To fix this:

Add the following

body.hasHelloBar #editor {
   height: calc(100vh - 256px);
}

body.hasHelloBar #sidebar{
   height: calc(100vh - 256px);
}

This will force the editor to be aligned with the rest of the screen. Editor has a calculation, but it does not account for hello-bar being opened.

The second allows for the advertisements to be shown when hello-bar is open.

@Betanu701
Copy link
Author

Also, The settings popup gets pushed off screen. You can add the following to fix it as well.

body.hasHelloBar .dropdownCont .dcWrapper{
    height: calc(100vh - 300px);
}

Note: 256 seems to be the magic number, at least on my system on different screens. The popup is pushed a little further so 300 seems to work. Feel free to fiddle with these if you wish.

@oskarkrawczyk
Copy link
Member

This is by design.

@jsfiddle jsfiddle locked as resolved and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants