chore: revamp build setup + bump/prune deps #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
chore: jsdoc stuff
can't use `@jest/globals` import b/c tests are executed with karma too, which will throw `Uncaught Error: Do not import `@jest/globals` outside of the Jest test environment.
replace `concurrently` setup with wireit's service feature
this doesn't seem to be used, added in commit 9605d4b
remove deprecated babel plugins and `regenerator-runtime`, update browser target and deps
Closed
mshanemc
approved these changes
Nov 20, 2023
| throw new Error( | ||
| 'Set SF_HUB_USERNAME, SF_OAUTH2_JWT_KEY and SF_OAUTH2_CLIENT_ID env vars.', | ||
| ); | ||
| } |
There was a problem hiding this comment.
DEVELOPING.md should probably say in a stronger way that sf is required.
| * @param interval Polling interval in milliseconds | ||
| * @param timeout Polling timeout in milliseconds | ||
| * @returns {Promise<Record[]>} A promise that resolves to an array of records | ||
| */ |
There was a problem hiding this comment.
thank you for the comments
test: fix flaky tests
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a lot of changes:
build setup
wireitfor build/test scriptstscinstead of babelsrc, 1 fortestfolders)deps
others
DEVELOPING.mdfile with instructions about how to build and run tests locallyquerystringmodule withURLSearchParams@W-14243612@