Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wr/eslintII #1416

Merged
merged 10 commits into from
May 14, 2024
Merged

Wr/eslintII #1416

merged 10 commits into from
May 14, 2024

Conversation

WillieRuemmele
Copy link
Collaborator

adds more eslint rules, fixes where reasonable

@W-15061342@

@WillieRuemmele WillieRuemmele force-pushed the wr/eslintII branch 2 times, most recently from 5705bad to 566bedd Compare May 7, 2024 19:51
src/api/bulk2.ts Outdated Show resolved Hide resolved
src/api/bulk2.ts Outdated Show resolved Hide resolved
src/api/bulk2.ts Outdated Show resolved Hide resolved
src/api/bulk2.ts Outdated Show resolved Hide resolved
src/request.ts Outdated Show resolved Hide resolved
Copy link
Member

@cristiand391 cristiand391 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments/suggestions.

Can you remove the dist changes? those should be pushed on release (which doesn't seem to be happen for v3, I'll create a WI for that).

@cristiand391
Copy link
Member

external NUTs passed but I also manually checked it didn't break builds, seems fine since not all interface->type changes were exported.

Can you remove the dist changes? those should be pushed on release (which doesn't seem to be happen for v3, I'll create a WI for that).

logged W-15758092 to remove these bundles.

@cristiand391 cristiand391 merged commit 60de980 into 3.0 May 14, 2024
16 checks passed
@cristiand391 cristiand391 deleted the wr/eslintII branch May 14, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants