-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wr/eslintII #1416
Wr/eslintII #1416
Conversation
3e77400
to
58393a8
Compare
50ac7c9
to
15e7a84
Compare
5705bad
to
566bedd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments/suggestions.
Can you remove the dist
changes? those should be pushed on release (which doesn't seem to be happen for v3, I'll create a WI for that).
external NUTs passed but I also manually checked it didn't break builds, seems fine since not all interface->type changes were exported.
logged W-15758092 to remove these bundles. |
adds more eslint rules, fixes where reasonable
@W-15061342@