mypy fixups #4
Merged
mypy fixups #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpkroth
commented
May 16, 2024
| @@ -348,8 +348,8 @@ def _register( | |||
| """ | |||
| with self.lock: | |||
| # Register each trial (one-by-one) | |||
| contexts: List[pd.Series] | List[None] = _to_context(context) or [ | |||
| None for _ in scores | |||
| contexts: Union[List[pd.Series], List[None]] = _to_context(context) or [ | |||
There was a problem hiding this comment.
need to support older versions of python
| @@ -361,8 +361,9 @@ def _register( | |||
| ) | |||
|
|
|||
| # Retrieve previously generated TrialInfo (returned by .ask()) or create new TrialInfo instance | |||
| matching: pd.Series[bool] | |||
There was a problem hiding this comment.
consistent typing info across branches
| @@ -182,7 +182,7 @@ def test_create_optimizer_with_factory_method( | |||
|
|
|||
| assert optimizer.parameter_space is not None | |||
|
|
|||
| suggestion, context = optimizer.suggest() | |||
| suggestion, _ = optimizer.suggest() | |||
|
For future reference the following will run these tests: make checkInternally the runs the following: make pycodestyle
make pydocstyle
make pylint
make mypyIt also runs them inside an appropriate make CONDA_ENV_NAME=mlos-3.8 mypyYou can run them all individually as well that way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.