Gostorm now correctly skips task_ids. Reverts the changes made in PR#5 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses Issue #4 - Spouts synchronous reading of task Ids should depen...
Fixes the splitsentence example by passing a ptr to the Read method
Changes imports so that the fork is self-contained.
Adds the Log interface to the collector interfaces.
Conflicts: messages/messages.go
…s respecting its (secret) wishes
Always request task ids from spout, since its unclear whether storm supports skipping.
|
sorry - meant to submit this to my branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reverts the changes I made in #5.
I submitted a fix to gostorm for handling the undocumented "need_task_ids" field of the multilang protocol, which removes the need for us to require task_ids for spouts/bolts.
This will also allow us to re-enable the event_receiver bolt in the topology.