Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET naming conventions #5

Closed
mscappini opened this issue Sep 3, 2015 · 1 comment
Closed

.NET naming conventions #5

mscappini opened this issue Sep 3, 2015 · 1 comment

Comments

@mscappini
Copy link
Contributor

Some simple changes that I have noticed so far that I would change to follow the .NET conventions. Feel free to disregard and close the issue if you disagree. 馃槃

Interfaces like QbRequest, QbIteratorRequest, QbResponse, and QbIteratorResponse should begin with a capital I. (Were these autogenerated?)

This is a matter of opinion: I feel that StepQueryResponseBase<T, Y>.GetName() should be an abstract property if its only purpose is to return a string with a name. I think making it a property will convey the idea that it should be simple and nothing complicated.

@jsgoupil
Copy link
Owner

jsgoupil commented Sep 3, 2015

I agree on both.

I have been working in TypeScript before and I dropped usage of I for a long time. My other projects use I for all my interfaces 馃憤

jsgoupil added a commit that referenced this issue Sep 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants