Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common interfaces for most *Ret types #45

Merged
merged 3 commits into from
Jun 6, 2020

Conversation

tofer
Copy link
Contributor

@tofer tofer commented Jun 4, 2020

Adds IQbListRet and IQbTxnRet interfaces, with a common IQbRet interface between them. MemberEnhancer and TypeEnahcner are modified to add inheritance of these interface to the *Ret types accordingly during generation from XSD.

Also adds an additional generic version of IQbResponse that provides an interface level method to retrieve the *Ret object from a response. The non-generic version is inherited, making this a non-breaking change.

@tofer tofer mentioned this pull request Jun 4, 2020
src/QbXml/Objects/IQbAddress.cs Outdated Show resolved Hide resolved
src/QbXml/Objects/IQbListRet.cs Show resolved Hide resolved
@jsgoupil
Copy link
Owner

jsgoupil commented Jun 4, 2020

Thanks! I'll merge that and bump the version soon.

@jsgoupil jsgoupil merged commit 2644a55 into jsgoupil:master Jun 6, 2020
@tofer tofer deleted the feature/common-interfaces branch June 19, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants