forked from kiali/kiali
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- I'm not sure if telemetry changed recently but when making requests of a service entry the telemetry may not include any cluster or namespace information, just the destination_service_name (i.e. the requested host) - The subsequent "unknown" values for cluster and namespace can not be used to help fetch the ServiceEntry config for matching. Depending on random node ordering, sometimes we would "get lucky" and fetch the needed information, but the whole approach was inherently flawed. - ServiceEntry definitions are really used by the source node, to properly route out of the mesh, and so the SE definition should really be fetched using the source node's cluster+namespace information (or so I currently think). This PR makes that change. - The PR also adds a useful optimization that can speed up this appender; or namespaces that only have injected service nodes we will no longer bother with loading SE definitions or doing the matching, because injected service nodes are not going to be converted to a ServiceEntry. kiali#6962
- Loading branch information
Showing
4 changed files
with
105 additions
and
58 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters