[Feature] Add laravel 6 support #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshayes
requested changes
Jan 15, 2020
| @@ -10,12 +10,12 @@ | |||
| ], | |||
| "require": { | |||
| "guzzlehttp/guzzle": "^6.3", | |||
| "illuminate/support": "^5.4", | |||
| "phpunit/phpunit": "~6.0|~7.0|~8.0" | |||
| "illuminate/support": "^6.0", | |||
There was a problem hiding this comment.
I'm down with not supporting 5.8 anymore since LTS will end for it soon.
There was a problem hiding this comment.
I don't think it would be possible to support both together either
.travis.yml
Outdated
| - php: 7.1 | ||
| env: ILLUMINATE_VERSION=5.7.* | ||
| - php: 7.1 | ||
| env: ILLUMINATE_VERSION=5.8.* | ||
| - php: 7.2 | ||
| env: ILLUMINATE_VERSION=5.7.* |
There was a problem hiding this comment.
Can get rid of the matrix I think. All that is needed for now would be
php:
- '7.2'
- '7.3'
- '7.4'
jshayes
approved these changes
Jan 16, 2020
|
This is available in release version 3.0 |
|
Thanks for the super quick review @jshayes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to update a few tests as well.