Prepare site for 2020 #385 #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://jsheroesio-git-385preparefor2020.clujsers.now.sh |
alexnm
requested changes
Jun 6, 2019
| describe('Website navigation', () => { | ||
| it('is a11y compliant', () => { | ||
| // TODO - Will be fixed later | ||
| it.skip('is a11y compliant', () => { |
There was a problem hiding this comment.
anything in particular failing in this test? I could have a look in the weekend
alexnm
approved these changes
Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #388 #386
#387 is not done in this commit
additional fixes:
added .editorconfig for keeping the formatting style
fixed jest & cypress warnings in vscode (it, cy globals)
fixed dependency issues.
commented
the tests for a11y - i didn't knew what was the problem there.