Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor changes for supported versions of Checkstyle #424

Merged
merged 1 commit into from Jan 14, 2019

Conversation

tsjensen
Copy link
Contributor

Hi, I just noticed some major cleanup of the supported versions, and as you might expect, and I can't let the opportunity pass by without giving some comments.

TL/DR: We should make the changes in this PR. πŸ˜‰

Long version:

  • 6.12 β†’ 6.12.1: probably ok, as people only see some warnings disappear
  • 7.1, 7.1.1 β†’ 7.1.2: probably ok too, as they tried to fix the equals/hashCode behavior. But that behavior does differ between versions.
  • 7.6 β†’ 7.6.1: I actually added back 7.6, because it threw different exceptions from the API, and this breaks custom checks
  • 8.4 β†’ 8.5: βœ”
  • 8.11, 8.12, 8.13 β†’ 8.14: βœ”
  • I added 8.9 β†’ 8.10.1
  • plus, I added a mapping for 8.15 β†’ 8.16, as these versions appear to be compatible, and 8.15 was missing so far.

Hope this helps!

@jshiell
Copy link
Owner

jshiell commented Jan 14, 2019

Magic - thank you! A second pair of eyes on this stuff is awesome, and I, as always, am much obliged.

jshiell added a commit that referenced this pull request Jan 14, 2019
tsjensen pushed a commit to tsjensen/checkstyle-idea that referenced this pull request Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants