-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why have launchpad.conf? #9
Comments
Well, I did this for several reasons - some preference, some technical limitation. First of all, I feel like it wouldn't be a great developer experience to have to declare arguments in your |
@jshimko Thanks for the response. What I meant was actually use the Dockerfile ARG, similar to ENV, which allows variables to be used at build runtime. https://docs.docker.com/engine/reference/builder/#/arg BTW: can I get you input here: https://forums.meteor.com/t/docker-team-up-to-create-a-reference-docker-image-for-meteor/30829 I personally would like to see your implementation be the MDG recommended version. |
Thanks @keyscores. I'll take a closer look later today. |
Thanks for this repository, it's great, I know nothing about meteor but this has helped a lot to learn the build process and it just works! 🌟 I also agree with @keyscores , personally I find adding a Ref PR 9 |
Most of the environment variable options that were available have now been given https://github.com/jshimko/meteor-launchpad#build-options For those that prefer it, the launchpad.conf will still work, but now you can also use the --build-arg flag when building your image. docker build --build-arg INSTALL_MONGO=true -t myorg/myapp:latest . |
Firstly, thanks for a well maintained docker image!
Couldn't this use ARG in the dockerfile? IMHO it would be cleaner to have those definitions in one file.
https://docs.docker.com/engine/reference/builder/#/arg
Thanks again
The text was updated successfully, but these errors were encountered: