Add --build-arg and remove launchpad.conf
#30
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this repository, it's great, I know nothing about meteor but this has helped a lot to learn the build process and it just works! 馃専
I find adding a
.conf
file means learning yet another convention, use of--build-arg
shouldbe easier and is already a convention for docker.
I didn't test this PR it for every different argument...
Ref issue 9