Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for auth method extension points #40

Closed
wants to merge 1 commit into from

Conversation

gyorokpeter
Copy link

Add ability to define custom auth methods. The auth method is invoked immediately before opening the connection, so for example it could generate a token to be passed in the Password field. The token generation might be an async function. The default "Username and Password" auth method returns the connection properties unchanged.

© 2021 Morgan Stanley.
THIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE MIT License. YOU MAY OBTAIN A COPY OF THE LICENSE AT https://github.com/jshinonome/vscode-q/blob/master/LICENSE.
THIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.

@mcleo-d
Copy link

mcleo-d commented Jul 7, 2021

Hi @jshinonome 👋🏻

I'm James McLeod, FINOS Director of Community, and I'd like to invite you to the FINOS KDB+ Project call on Monday 12th July 2021 at 9:00am EST / 2:00pm BST where the call details can be found here ... finos/kdb#50

During the call I'd like to introduce you to @alvin-c-shih, KDB+ Lead Maintainer from Morgan Stanley, and the KDB+ project team that also includes @gyorokpeter who raised this pull request.

Also on the agenda is @ColinEberhardt from Scott Logic who is introducing the team to KDB Studio 2 Prototype that's found in the following issue finos/kdb#51 as we'd really appreciate your input and feedback.

Thanks so much for considering this request and I look forward to hearing from you soon.

James.

@jshinonome
Copy link
Owner

Hi @mcleo-d

Thanks for the invitation. I would be happy to join the meeting. Looking forward to meeting you during the meeting.

Kind regards,
Jo

@jshinonome
Copy link
Owner

jshinonome commented Jul 9, 2021 via email

@jshinonome
Copy link
Owner

As discussed, I will update my extension, and allow it to load the authentication method from another plugin. Also, provide a prototype of auth plugin to @gyorokpeter.

@jshinonome
Copy link
Owner

@gyorokpeter vscode-q v2.2.7 allows using customized authentication. Please refer to this repo for details: https://github.com/jshinonome/vscode-q-auth
After you created vscode-q-auth yourself, you can manually install it from vscode. When Customized Authentication is checked, it will load vscode-q-auth and use getToken() before connecting to the process.
Happy to jump a meeting if you need any clarification.

@jshinonome jshinonome closed this Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants