This repository has been archived by the owner on Aug 28, 2023. It is now read-only.
Add exchangeratesapi.io support #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maennchen
suggested changes
Nov 28, 2019
There was a problem hiding this comment.
Could you mention the new source here: https://github.com/jshmrtn/currency-conversion/blob/master/README.md#configuration ?
|
Yes, will do. |
strzibny
force-pushed
the
exchangeratesapi-support
branch
from
64a6802
to
dbae00a
Compare
|
I added it and made both link to the their respective services. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should add support for exchangeratesapi free & open source service. It's based on Fixer API so most code is the same. However it's free service so there is no token and I felt it might be cleaner and better path for the future to have it separately rather then adjusting the Fixer file. What do you think?