Skip to content
This repository has been archived by the owner on Aug 28, 2023. It is now read-only.

Dialyzer Fixes & Test CI #5

Merged
merged 1 commit into from Mar 1, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions .travis.yml
Expand Up @@ -24,6 +24,12 @@ jobs:
- MIX_ENV=dev
script: mix format --check-formatted
elixir: 1.6
- stage: dialyzer
env:
- MIX_ENV=dev
before_script: travis_wait mix dialyzer --plt
script: mix dialyzer --halt-exit-status
elixir: 1.6
- stage: inch
env:
- MIX_ENV=docs
Expand Down
17 changes: 17 additions & 0 deletions lib/ex_saferpay/request/card_form.ex
@@ -0,0 +1,17 @@
defmodule ExSaferpay.Request.CardForm do
@moduledoc """
Request Body for CardForm
"""

use ExSaferpay.RequestNormalizer

@type t :: %__MODULE__{
holder_name: nil | String.t()
}

@enforce_keys []
defstruct @enforce_keys ++
[
:holder_name
]
end
18 changes: 18 additions & 0 deletions lib/ex_saferpay/request/check.ex
@@ -0,0 +1,18 @@
defmodule ExSaferpay.Request.Check do
@moduledoc """
Request Body for Check
"""

use ExSaferpay.RequestNormalizer

@type t :: %__MODULE__{
type: :online,
terminal_id: String.t()
}

@enforce_keys [
:type,
:terminal_id
]
defstruct @enforce_keys
end
2 changes: 1 addition & 1 deletion lib/ex_saferpay/response/transaction.ex
Expand Up @@ -16,7 +16,7 @@ defmodule ExSaferpay.Response.Transaction do
status: status,
id: String.t(),
date: DateTime.t(),
amount: Response.Amount.t(),
amount: Money.t(),
order_id: nil | String.t(),
acquirer_name: nil | String.t(),
acquirer_reference: nil | String.t(),
Expand Down
4 changes: 2 additions & 2 deletions lib/ex_saferpay/response_normalizer.ex
Expand Up @@ -33,7 +33,7 @@ defmodule ExSaferpay.ResponseNormalizer do

def transform(input, Date) do
case Date.from_iso8601(input) do
{:ok, date, _} ->
{:ok, date} ->
date

{:error, error} ->
Expand All @@ -43,7 +43,7 @@ defmodule ExSaferpay.ResponseNormalizer do
end

def transform(%{"CurrencyCode" => currency, "Value" => value}, Money) do
Money.new(String.to_integer(value) / 100, currency)
Money.from_float!(currency, String.to_integer(value) / 100)
end

def transform(input, Money) do
Expand Down