Skip to content
This repository has been archived by the owner on Jun 20, 2022. It is now read-only.

consider adding [an option to] print a message at the start of each recompile. #43

Closed
elenzil opened this issue Apr 16, 2019 · 4 comments · Fixed by #46
Closed

consider adding [an option to] print a message at the start of each recompile. #43

elenzil opened this issue Apr 16, 2019 · 4 comments · Fixed by #46
Labels
enhancement New feature or request

Comments

@elenzil
Copy link
Contributor

elenzil commented Apr 16, 2019

when saving changes to source,
it's sometimes nice to see positive confirmation that compilation succeeded.

@jshrake jshrake added the enhancement New feature or request label Apr 16, 2019
@elenzil
Copy link
Contributor Author

elenzil commented Apr 17, 2019

so afaict, Grimoire doesn't output anything to stdout currently: just stderr when there's trouble.
what's your thought about a feature like this which would be printing to stdout ?

in other news, i implemented a version of this but it feels not in keeping with the rest of the codebase, in terms of how it's printing etc. i've never worked with Rust and honestly i'm finding it a bit convoluted from my C11 perspective. perhaps i should read the manual ;)

jshrake added a commit that referenced this issue Apr 18, 2019
And update the README to mention log levels

Closes #43
bors bot added a commit that referenced this issue Apr 18, 2019
46: Use info! to log successful shader compilation changes r=jshrake a=jshrake

And update the README to mention log levels

Closes #43

Co-authored-by: Justin Shrake <justinshrake@gmail.com>
@jshrake
Copy link
Owner

jshrake commented Apr 18, 2019

I updated a few of the debug! statements to info! statements so that you can see successful shader compilations notices when running with RUST_LOG=info.

Grimoire doesn't output anything to stdout currently: just stderr when there's trouble.
what's your thought about a feature like this which would be printing to stdout ?

I use the log crate to manage logging. You'll need to specify the environment variable RUST_LOG=info to see these log messages. I updated the README to mention this environment variable as well.

@bors bors bot closed this as completed in #46 Apr 18, 2019
@jshrake
Copy link
Owner

jshrake commented Apr 18, 2019

Note that you could also run with RUST_LOG=debug, but it logs a lot of messages that aren't immediately useful. I'm not really pleased with the current logging situation in grimoire and plan to overhaul it at some point, as with all things :P

@elenzil
Copy link
Contributor Author

elenzil commented Apr 18, 2019

sweet!

thanks for your patience with my fumbling through Rust. eg cargo run instead of target/debug/....

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants