Skip to content
This repository has been archived by the owner on Jun 20, 2022. It is now read-only.

Make SRGB framebuffer configurable #50

Closed
jshrake opened this issue Apr 20, 2019 · 0 comments
Closed

Make SRGB framebuffer configurable #50

jshrake opened this issue Apr 20, 2019 · 0 comments
Assignees
@jshrake
Labels
enhancement New feature or request

Comments

@jshrake
Copy link
Owner

jshrake commented Apr 20, 2019 •
edited

I keep manually commenting and uncommenting glEnable(GL_FRAMEBUFFER_SRGB) to match various source material. Make it a configurable option, either at the command-line or in grim.toml. Of note, I believe at one point I disabled it to match source material on shadertoy, and then enabled it to match source imagery from http://jcgt.org/published/0002/02/09/paper.pdf while working on https://github.com/jshrake/grimoire/issues/34. I'm once again disabling it while working on #21
@jshrake jshrake added the enhancement New feature or request label Apr 20, 2019
@jshrake jshrake self-assigned this Apr 20, 2019
@jshrake jshrake changed the title SRGB framebuffer should be configurable Make SRGB framebuffer configurable Apr 20, 2019
jshrake added a commit that referenced this issue Apr 20, 2019
@jshrake
Update audio.rs to better match shadertoy
d631a26 
The FFT portion of examples/shadertoy-sound now looks much closer
to https://www.shadertoy.com/view/Xds3Rr. The waveform part still looks
a bit off, but I'm less concerned about that.

Note that I'm once again commenting out GL_FRAMEBUFFER_SRGB! See #50

Closes #21
@jshrake jshrake closed this as completed Mar 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jshrake jshrake

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jshrake