Improve error message when encode is not a function

closes #40
jshttp · May 26, 2016 · cabcda0 · cabcda0
1 parent 71dbc9e
commit cabcda0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/HISTORY.md b/HISTORY.md
@@ -3,6 +3,7 @@ unreleased
 
   * Add `sameSite` option
     - Replaces `firstPartyOnly` option, never implemented by browsers
+  * Improve error message when `encode` is not a function
 
 0.2.4 / 2016-05-20
 ==================

diff --git a/index.js b/index.js
@@ -102,6 +102,10 @@ function serialize(name, val, options) {
   var opt = options || {};
   var enc = opt.encode || encode;
 
+  if (typeof enc !== 'function') {
+    throw new TypeError('option encode is invalid');
+  }
+
   if (!fieldContentRegExp.test(name)) {
     throw new TypeError('argument name is invalid');
   }

diff --git a/test/serialize.js b/test/serialize.js
@@ -11,6 +11,7 @@ test('basic', function() {
     assert.equal('foo=', cookie.serialize('foo', ''));
     assert.throws(cookie.serialize.bind(cookie, 'foo\n', 'bar'), /argument name is invalid/);
     assert.throws(cookie.serialize.bind(cookie, 'foo\u280a', 'bar'), /argument name is invalid/);
+    assert.throws(cookie.serialize.bind(cookie, 'foo', 'bar', {encode: 42}), /option encode is invalid/);
 });
 
 test('path', function() {