-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: invalid value Infinity for maxAge #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I made a few suggestion, let us know what you think. |
This is better solution. As per your suggestion fixes are added into pull request |
Travis is falling as isFinite is not supported by Nodejs 0.6 version |
Yea, I believe the updated recommendation was to use the |
Let me try with global isFinite function. |
Regarding issue #103, We should handle +Infinity and -Infinity for maxAge value