Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handle special Object properties #145

Closed
wants to merge 1 commit into from

Conversation

repsac-by
Copy link

Handling of special Object properties such as toString, __proto__, etc..

@dougwilson
Copy link
Contributor

Hello, and thank you for your pull request. Unfortunately this is not going to be able to land any time soon, as downstream expects the returned object to inherit from Object.prototype, which is why cookies named things like __proto__ are ignored by this module. Returning an object that includes these named-properties ends up causing issues with consumers due to various merge utilities. Ignoring these named-cookies was done to resolve a security report.

@dougwilson dougwilson closed this Oct 2, 2022
@repsac-by repsac-by deleted the handle-special-properties branch October 2, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants