Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: put exports at the end of the file #98

Closed
wants to merge 1 commit into from

Conversation

tim-kilian
Copy link

Closes #97

Changes

  • First define methods and then assign it afterwards to exports

@dougwilson
Copy link
Contributor

Thanks, but I prefer them to be at the top so seeing them is obvious. It is 100% valid comon JS export usage and javascript. It sounds like perhaps a bug should be reported to your editor, unless you can provide official documentation from your editor that says this is required.

@dougwilson dougwilson closed this Feb 15, 2020
@dougwilson dougwilson added the pr label Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export statement should be placed at the bottom of the script for editor support
2 participants