Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced function for extension to use it with Angular v6 #52

Closed
wants to merge 2 commits into from

Conversation

marlon360
Copy link

Removed the 'path' dependency from NodeJS and replaced it with own function to use this package with Angular v6.

Replaced NodeJS dependency 'path' and replaced it with own function to use this package with Angular v6.
Copy link
Contributor

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The agreement was to replace it with an npm module, not a ball of code I have to maintain.

@dougwilson
Copy link
Contributor

Also, besides replacing this with a module, the tests need to be added that test the module in a Angular/ browser environment. I believe the proposal was to use Karma to do that 👍

@marlon360
Copy link
Author

Found a better solution: #53
Your code stays untouched, but a bundler builds the browser version.
The tests also stay the same, but run with karma in a browser (see Travis at node v6).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants