Update node 8 version and pin nyc. Also added missing 9.x to ci-tests… #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carpasse
force-pushed
the
ci/fix_test_in_node_8_and_9
branch
2 times, most recently
from
588707d
to
474b678
Compare
wesleytodd
approved these changes
Mar 27, 2024
|
Node 9 seems to fail. I am investigating |
carpasse
force-pushed
the
ci/fix_test_in_node_8_and_9
branch
from
474b678
to
2a045c5
Compare
|
I think there is a bug in node 9 http_parser or on the http server. Which is the reason why the tests are failing on node 9. I've tried to make it fail differently but nothing I do causes the error to be propagated to the on-finished handler I've removed node 9 form the ci-tests gh action as it is currently and I will try to investigate a bit further separately. |
|
Ah, that does ring a bell for me. That said, we should probably leave a comment in the yaml file to the reason it is excluded or something to prevent future confusion. Future really is we remove all this as we drop support with the next major, but that will be a bit for this one I think. |
closes jshttp#48 Similar fix as jshttp/http-errors#109
carpasse
force-pushed
the
ci/fix_test_in_node_8_and_9
branch
from
2a045c5
to
12be913
Compare
UlisesGascon
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… action
closes #48
Similar fix as jshttp/http-errors#109