Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with pre-commit integration #50

Closed
jshwi opened this issue Dec 24, 2022 · 0 comments · Fixed by #51
Closed

Issue with pre-commit integration #50

jshwi opened this issue Dec 24, 2022 · 0 comments · Fixed by #51
Assignees

Comments

@jshwi
Copy link
Owner

jshwi commented Dec 24, 2022

Hello @jshwi,

Trying to test this I found a bug related to the pre-commit configuration.

pre-commit-config.yaml

-   repo: https://github.com/jshwi/docsig
    rev: v0.33.0
    hooks:
      - id: docsig
        name: docsig
        entry: docsig
        language: system
        types: [python]
        require_serial: true
        args:
          - "-i"
          - "--ignore-kwargs"

I get an error: docsig: error: unrecognized arguments: --ignore-kwargs

Then I tried manually and the version wasn't the latest. After the manual update (pip install -U docsig), both manual and pre-commit worked.

This shouldn't be the case since I've specified the exact version in the pre-commit (I guess it should have it's own environment based on the yaml specification).

Can you check if this is due to bad integration?

Regarding the feature itself, everything seems to be working as expected so far. 🎉

Best, Lazar

@jshwi jshwi self-assigned this Dec 24, 2022
jshwi added a commit that referenced this issue Dec 24, 2022
Example .pre-commit-hooks.yaml was based on `pylint`, a local install
@jshwi jshwi linked a pull request Dec 24, 2022 that will close this issue
@jshwi jshwi closed this as completed in #51 Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant