[voice_text] Add respawn argument for sound_play #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-okada
reviewed
Oct 17, 2017
| @@ -7,6 +7,8 @@ | |||
| <arg name="use_machine" default="true" /> | |||
| <machine if="$(arg use_machine)" name="localhost" address="localhost" /> | |||
|
|
|||
| <arg name="sound_play_respawn" default="false" /> | |||
There was a problem hiding this comment.
is there any problem if set default=true ?
Cc: @furushchev
There was a problem hiding this comment.
Thanks for reviewing!
I have no problem.
How about you? @furushchev
There was a problem hiding this comment.
OK, I'll update this PR to do so!
snozawa
force-pushed
the
add_respawn_flag
branch
from
752f042
to
b06cc69
Compare
|
I updated the PR and travis passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[voice_text] Add respawn argument for sound_play