Add respeaker_ros package #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-okada
requested changes
Aug 28, 2018
respeaker_ros/README.md
Outdated
|
|
||
| ```bash | ||
| mkdir -p ~/catkin_ws/src && ~/catkin_ws/src | ||
| git clone https://github.com/furushchev/respeaker_ros.git |
There was a problem hiding this comment.
@k-okada Thanks! Fixed.
respeaker_ros/README.md
Outdated
|
|
||
| ## Preparation | ||
|
|
||
| 1. Build this package |
There was a problem hiding this comment.
add how to use with deb package
| # | ||
| # To generate this file, please run: | ||
| # cd /path/to/this/package | ||
| # python ./scripts/respeaker_gencfg.py |
There was a problem hiding this comment.
please add when we need to run ./scripts/respeaker_gencfg.py in README.md or, may be you 'd better to use cmake to generate this file.
There was a problem hiding this comment.
@k-okada This script is to get default value from the device as current values.
That is what I thought once before, but it requires device connected on build time.
I added an instruction to the readme.
There was a problem hiding this comment.
I see, so add how to use this script and when we need to generate this file
k-okada
approved these changes
Aug 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a package that provides a driver for Respeaker v2 multi microphone array device.
Please see the README for more detail.
https://github.com/furushchev/jsk_3rdparty/blob/2d6cadb38aca49e8e3307fdd1f6e8aca5b488572/respeaker_ros/README.md
ros/rosdistro#18923 is required