[switchbot_ros] add actionlib_msgs and std_msgs as build_depend

[knorth55]

this PR solve #356
add actionlib_msgs and std_msgs as build_depend.
these packages are used in CMakeLists.txt.

jsk_3rdparty/switchbot_ros/CMakeLists.txt

Lines 23 to 27 in f0ab7bb

	generate_messages(
	DEPENDENCIES
	std_msgs
	actionlib_msgs
	)

[mqcmd196]

LGTM

[k-okada]

if executable file requires std_msgs, you need to add std_msgs to exec_depend -- ◉ Kei Okada 2022年7月15日(金) 12:25 Shingo Kitagawa ***@***.***>:

…

***@***.**** commented on this pull request. ------------------------------ In switchbot_ros/package.xml <#357 (comment)> : > <exec_depend condition="$ROS_PYTHON_VERSION == 2">python-requests</exec_depend> <exec_depend condition="$ROS_PYTHON_VERSION == 3">python3-requests</exec_depend> <exec_depend>actionlib</exec_depend> <exec_depend>message_runtime</exec_depend> <exec_depend>rospy</exec_depend> - <exec_depend>std_msgs</exec_depend> Anyway, We need to check if we can generate deb file and install correctly. — Reply to this email directly, view it on GitHub <#357 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADYNXCXYIX3KBFN6BWLYWDVUDKV5ANCNFSM53RQ7L2Q> . You are receiving this because you commented.Message ID: ***@***.***>

[knorth55]

Now I can reproduce the same error of build.ros.org locally.

docker run -it osrf/ros:melodic-desktop-bionic /bin/bash
# in docker
curl -s https://raw.githubusercontent.com/ros/rosdistro/master/ros.asc | apt-key add -
apt update
apt install python-bloom
apt install fakeroot dpkg-dev debhelper

cd 
git clone https://github.com/jsk-ros-pkg/jsk_3rdparty.git
cd jsk_3rdparty/switchbot_ros
bloom-generate rosdebian --os-name ubuntu --os-version bionic --ros-distro melodic
apt purge ros-melodic-std-msgs ros-melodic-actionlib-msgs

dpkg-buildpackage -rfakeroot -uc -b

When I install both ros-melodic-std-msgs and ros-melodic-actionlib-msgs, the build can correctly done.

So the dependencies for std_msg and actionlib_msgs was missing.

[mqcmd196]

@knorth55 I confirmed same error after executing

apt purge ros-melodic-std-msgs ros-melodic-actionlib-msgs

in osrf/ros:melodic-desktop-bionic

[mqcmd196]

Thank you for telling me the way to make .deb in locally.
With this PR, in osrf/ros:melodic-desktop-bionic image,

$git clone https://github.com/knorth55/jsk_3rdparty.git --branch fix-switchbot-deps
$cd jsk_3rdparty/switchbot_ros/
$apt update
$apt install curl
$apt install python-bloom fakeroot dpkg-dev debhelper
$apt purge ros-melodic-std-msgs ros-melodic-actionlib-msgs
$bloom-generate rosdebian --os-name ubuntu --os-version bionic --ros-distro melodic
$dpkg-buildpackage -rfakeroot -uc -b
dpkg-buildpackage: warning:     debian/changelog(l5): found trailer where expected start of change data
LINE:  -- Kei Okada <k-okada@jsk.t.u-tokyo.ac.jp>  Mon, 26 Jul 2021 00:00:00 -0000
dpkg-buildpackage: warning: using a gain-root-command while being root
dpkg-buildpackage: info: source package ros-melodic-switchbot-ros
dpkg-buildpackage: info: source version 2.1.24-0bionic
dpkg-buildpackage: info: source distribution bionic
dpkg-buildpackage: info: source changed by Kei Okada <k-okada@jsk.t.u-tokyo.ac.jp>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build switchbot_ros
dpkg-source: info: using options from switchbot_ros/debian/source/options: --auto-commit
dpkg-source: warning: switchbot_ros/debian/changelog(l5): found trailer where expected start of change data
LINE:  -- Kei Okada <k-okada@jsk.t.u-tokyo.ac.jp>  Mon, 26 Jul 2021 00:00:00 -0000
dpkg-checkbuilddeps: error: Unmet build dependencies: ros-melodic-actionlib ros-melodic-actionlib-msgs ros-melodic-std-msgs
dpkg-buildpackage: warning: build dependencies/conflicts unsatisfied; aborting
dpkg-buildpackage: warning: (Use -d flag to override.)

dpkg-buildpackage recognizes the dependencies and doesn't begin to build the package. It failes in dpkg-checkbuilddeps phase. In origin/master, it starts building and fails with cmake's building phase.
After the execution of apt install ros-melodic-std-msgs ros-melodic-actionlib-msgs ros-melodic-actionlib , it successfully builds.