[switchbot_ros] build failure on build.ros.org

[knorth55]

switchbot_ros fails building on build.ros.org in 2.1.24.

https://build.ros.org/job/Mbin_uB64__switchbot_ros__ubuntu_bionic_amd64__binary/
https://build.ros.org/job/Mbin_ubhf_uBhf__switchbot_ros__ubuntu_bionic_armhf__binary/
https://build.ros.org/job/Mbin_ubv8_uBv8__switchbot_ros__ubuntu_bionic_arm64__binary/

I guess this build error may be caused by missing message_generation dependencies in package.xml.

jsk_3rdparty/switchbot_ros/package.xml

Lines 12 to 17 in 622d2c0

	<buildtool_depend>catkin</buildtool_depend>
	<run_depend>python-requests</run_depend>
	<run_depend>message_runtime</run_depend>
	<run_depend>rospy</run_depend>
	<run_depend>std_msgs</run_depend>

This missing dependency problem is solve in d7c52cc, so the package build may be succeeded in next release.

cc. @mqcmd196 @sktometometo

this issue is related to jsk-ros-pkg/jsk_robot#1508

[knorth55]

I didn't check deeply about the build error, so we need to check the build error deeply.

[knorth55]

I checked a little bit and I add more missing dependencies in #357

related: #357 #358

[mqcmd196]

Thank you for your check, I confirmed that I can get the email, so I'll check the buildfarm carefully.

[knorth55]

Now I can reproduce the same error of build.ros.org locally.

docker run -it osrf/ros:melodic-desktop-bionic /bin/bash
# in docker
curl -s https://raw.githubusercontent.com/ros/rosdistro/master/ros.asc | apt-key add -
apt update
apt install python-bloom
apt install fakeroot dpkg-dev debhelper

cd 
git clone https://github.com/jsk-ros-pkg/jsk_3rdparty.git
cd jsk_3rdparty/switchbot_ros
bloom-generate rosdebian --os-name ubuntu --os-version bionic --ros-distro melodic
apt purge ros-melodic-std-msgs ros-melodic-actionlib-msgs

dpkg-buildpackage -rfakeroot -uc -b

When I install both ros-melodic-std-msgs and ros-melodic-actionlib-msgs, the build can correctly done.

So the dependencies for std_msg and actionlib_msgs was missing.

[knorth55]

I carefully read the build log and I found the following error in build.ros.org.
The error shows that actionlib_msgs is not installed.
https://build.ros.org/job/Mbin_uB64__switchbot_ros__ubuntu_bionic_amd64__binary/364/consoleFull#console-section-8

15:04:22 -- Could NOT find actionlib_msgs (missing: actionlib_msgs_DIR)
15:04:22 -- Could not find the required component 'actionlib_msgs'. The following CMake error indicates that you either need to install the package with the same name or change your environment so that it can be found.
15:04:22 CMake Error at /opt/ros/melodic/share/catkin/cmake/catkinConfig.cmake:83 (find_package):
15:04:22   Could not find a package configuration file provided by "actionlib_msgs"
15:04:22   with any of the following names:
15:04:22 
15:04:22     actionlib_msgsConfig.cmake
15:04:22     actionlib_msgs-config.cmake
15:04:22 
15:04:22   Add the installation prefix of "actionlib_msgs" to CMAKE_PREFIX_PATH or set
15:04:22   "actionlib_msgs_DIR" to a directory containing one of the above files.  If
15:04:22   "actionlib_msgs" provides a separate development package or SDK, be sure it
15:04:22   has been installed.
15:04:22 Call Stack (most recent call first):
15:04:22   CMakeLists.txt:4 (find_package)
15:04:22 
15:04:22 
15:04:22 -- Configuring incomplete, errors occurred!
15:04:22 See also "/tmp/binarydeb/ros-melodic-switchbot-ros-2.1.24/.obj-x86_64-linux-gnu/CMakeFiles/CMakeOutput.log".
15:04:22 See also "/tmp/binarydeb/ros-melodic-switchbot-ros-2.1.24/.obj-x86_64-linux-gnu/CMakeFiles/CMakeError.log".