Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chaplus_ros]support mebo #374

Merged
merged 4 commits into from Aug 19, 2022
Merged

[chaplus_ros]support mebo #374

merged 4 commits into from Aug 19, 2022

Conversation

MiyabiTane
Copy link
Contributor

Chaplusのサポートが終了するため、meboに対応しました

@MiyabiTane MiyabiTane mentioned this pull request Aug 16, 2022
@MiyabiTane MiyabiTane changed the title support mebo [chaplus_ros]support mebo Aug 16, 2022
Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

  1. please consider merging simple_example.launch and https://github.com/jsk-ros-pkg/jsk_3rdparty/blob/master/chaplus_ros/sample/google_example.launch. For example add <arg name="use_speech_input" value="true" doc="set false to send input via /speech_to_text???">
  2. please update README.md to how to use sample launch file for biginners, publishes /robotsound_jp [sound_play/SoundRequest], For example run rostopic pub ..... to send commands and rostopic sub ... to get responce. You can also show sample conversation.
  3. If we can share the api key, put the sample key to https://drive.google.com/drive/folders/1OQRn5-3lOxzgWm7_p--T0KqGYNDxefvN only for JSk users and put the link to readme.md like https://github.com/jsk-ros-pkg/jsk_3rdparty/tree/master/dialogflow_task_executive#sample-programs-for-jsk-users

@MiyabiTane
Copy link
Contributor Author

Sorry for the delay. Thank you for your comments!

  1. I included simple_example.launch in google_example.launch, and added the arg use_respeaker.
  2. I updated the README.md. I show sample conversations using the log of launch file because the output of rostopic echo /robotsound_jp is garbled like this,
sound: -3
command: 1
volume: 1.0
arg: !!python/str "\u306A\u3093\u3060\u304B\u7652\u3055\u308C\u305D\u3046\u3067\u3059\u306D\
  \u3002"
arg2: ''

Is there a solution?
3. I added arg chaplus_apikey_file to google_example.launch

@k-okada
Copy link
Member

k-okada commented Aug 19, 2022

@MiyabiTane good question, see jsk-ros-pkg/jsk_demos#1347 (comment) to show multibyte charactors.

@tkmtnt7000
Copy link
Member

tkmtnt7000 commented Aug 19, 2022

@MiyabiTane good question, see jsk-ros-pkg/jsk_demos#1347 (comment) to show multibyte charactors.

https://github.com/jsk-ros-pkg/jsk_3rdparty/tree/master/respeaker_ros#how-to-use
This section is also helpful. See Voice recoginition result for Japanese.

@k-okada k-okada merged commit fad69a4 into jsk-ros-pkg:master Aug 19, 2022
@MiyabiTane
Copy link
Contributor Author

Thank you for your merging!
Thank you Tsukamoto-kun, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants