Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] build catkin_virtualenv packages in indigo. #419

Merged
merged 7 commits into from Feb 24, 2023

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Dec 15, 2022

as mentioned in #410 (comment) ,
we need to avoid pip upgrade to the latest version in catkin_virtualenv.

this PR change upgrade_pip to false in indigo to avoid the upgrade.

@knorth55 knorth55 changed the title [CI] use catkin_virtualenv 0.5.3 for Indigo build [CI] use catkin_virtualenv 0.2.2 for Indigo build Dec 15, 2022
@knorth55 knorth55 changed the title [CI] use catkin_virtualenv 0.2.2 for Indigo build [CI] build catkin_virtualenv packages in indigo. Dec 15, 2022
@knorth55 knorth55 force-pushed the ci-indigo-catkin-virtualenv branch 2 times, most recently from 2bb62d3 to 9197264 Compare December 15, 2022 13:25
2022-12-15T12:46:31.7743481Z [dialogflow_task_executive:cmake] CMake Error at /github/home/ros/ws_jsk_3rdparty/src/jsk_3rdparty/dialogflow_task_executive/CMakeLists.txt:53 (file):
2022-12-15T12:46:31.7744180Z [dialogflow_task_executive:cmake]   file RENAME failed to rename
2022-12-15T12:46:31.7745364Z [dialogflow_task_executive:cmake]     /github/home/ros/ws_jsk_3rdparty/build/dialogflow_task_executive/requirements.txt.indigo
2022-12-15T12:46:31.7746572Z [dialogflow_task_executive:cmake]   to
2022-12-15T12:46:31.7747729Z [dialogflow_task_executive:cmake]     /github/home/ros/ws_jsk_3rdparty/src/jsk_3rdparty/dialogflow_task_executive/requirements.txt
2022-12-15T12:46:31.7749036Z [dialogflow_task_executive:cmake]   because: Invalid cross-device link
@knorth55 knorth55 force-pushed the ci-indigo-catkin-virtualenv branch 3 times, most recently from af3a605 to 6deaddb Compare December 16, 2022 09:04
@knorth55 knorth55 closed this Dec 16, 2022
@knorth55 knorth55 reopened this Dec 16, 2022
@knorth55 knorth55 force-pushed the ci-indigo-catkin-virtualenv branch 5 times, most recently from 5ac3c3f to 457ff6e Compare December 16, 2022 14:19
@knorth55 knorth55 added the bug label Dec 19, 2022
@knorth55
Copy link
Member Author

Now this PR passed all CI!
All green!
packages with catkin_virtualenv are built successfully in indigo, too.
@k-okada

@knorth55
Copy link
Member Author

all test passed, but the indigo workflow name changed, so the CI looks keep running.

-            BEFORE_SCRIPT : "for name in dialogflow_task_executive ros_speech_recognition sesame_ros respeaker_ros ffha libsiftfast nlopt julius julius_ros downward assimp_devel google_chat_ros; do echo \\$name; find $GITHUB_WORKSPACE -iname \\$name -exec touch {}/CATKIN_IGNORE \\; ; ls -al \\$(find -iname \\$name)/; done" # Skip large packagses /  Skip packages that could not build on indigo dialogflow_task_executive/ros_speech_recognition/sesame_ros/respeaker_ros
+            BEFORE_SCRIPT : "sudo pip install packaging==17.1; for name in ffha libsiftfast nlopt julius julius_ros downward assimp_devel google_chat_ros; do echo \\$name; find $GITHUB_WORKSPACE -iname \\$name -exec touch {}/CATKIN_IGNORE \\; ; ls -al \\$(find -iname \\$name)/; done" # Skip large packagses

https://github.com/jsk-ros-pkg/jsk_3rdparty/actions/runs/4020953518/jobs/6909391150

@k-okada k-okada merged commit 0f5ed41 into jsk-ros-pkg:master Feb 24, 2023
@knorth55 knorth55 deleted the ci-indigo-catkin-virtualenv branch February 24, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants