Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gdrive_ros] try authentication multiple times #249

Merged
merged 5 commits into from Jun 10, 2021
Merged

[gdrive_ros] try authentication multiple times #249

merged 5 commits into from Jun 10, 2021

Conversation

knorth55
Copy link
Member

try authentication multiple times in gdrive_ros

708yamaguchi
708yamaguchi approved these changes May 23, 2021
View reviewed changes
Copy link
Member

@708yamaguchi 708yamaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good to me.

One thing that I wonder about is time.sleep(10).
How did you decide on 10 seconds?
I feel waiting 10 seconds for each loop is a bit long .(But it doesn't matter)

@knorth55
Copy link
Member Author

@708yamaguchi
I add auth_wait_seconds parameter.
The reason why I set 10 seconds is because we need to wait internet reconnection.

@knorth55 knorth55 mentioned this pull request Jun 3, 2021
Closed
14 tasks
@k-okada k-okada merged commit 8d4cde8 into jsk-ros-pkg:master Jun 10, 2021
@knorth55 knorth55 deleted the try-auth-multiple branch June 10, 2021 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@708yamaguchi 708yamaguchi 708yamaguchi approved these changes

Assignees
No one assigned
Labels
gdrive_ros
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knorth55 @708yamaguchi @k-okada