Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]Google Chat ROS client #290
[WIP]Google Chat ROS client #290
Changes from all commits
ab015b8
bdeb2c1
e53907c
8041641
104c1bc
f769992
fb1b6ae
425c237
927a0a6
788b354
6d11f64
0e37857
8fd9fd9
2261c26
e772a0d
901b4e8
f6b03eb
a37f26f
94891f4
9d3b2e6
f294aa5
d15ab7a
6f1bc1c
31162b9
afa2b00
2eb7415
cc8c76c
f5c38fe
82d228b
557acd7
c1f9b46
ff12c5b
9811520
f7e028f
3524ceb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space
?ID
? conceptThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have to open any ports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is solved with #242 . This PR is just for sending message to specific chat space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is ROS interface for GoogleChat API, so please implement all (or almost all) methods described in https://developers.google.com/chat/api/reference/rest,
Using dialogflow is JSK's application, but jsk_3rdparty is designed for general interface for existing libraries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, I'll cover them.