Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text interface to dialogflow client #291

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sktometometo
Copy link
Contributor

@sktometometo sktometometo commented Oct 20, 2021

Add text interface to dialogflow client.

Usage

Setting up your dialogflow project and

roslaunch dialogflow_task_executive dialogflow_task_executive.launch run_task_executive:=false
rosrun dialogflow_task_executive text_chat_prompt.py
text_prompt.mp4
demo_started.mp4

@knorth55 knorth55 self-requested a review October 20, 2021 06:54
@k-okada k-okada added the hacktoberfest-accepted https://hacktoberfest.digitalocean.com/hacktoberfest-update label Oct 20, 2021
Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add example video, like jsk-ros-pkg/jsk_robot#1396

@sktometometo
Copy link
Contributor Author

Demo videoes are added.

Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sktometometo I think text prompt is nice feature, specially for debugging

  1. how about using simple text message for input, see
    f1ebed9
  2. I think text_chat_prompt.py can be generalized as ros_(string)_text_prompe.py, for example,
rosrun jsk_topic_tools?? text_prompt.py /text /dialog_response/response

I think this can be used for chatplos_ros, google_nlp ???

rosrun jsk_topic_tools?? text_prompt.py /chaplus_ros/request /chaplus_ros/response
rosrun jsk_topic_tools?? text_prompt.py /google_nlp/text/goal /google_nlp/result/entities

how do you think?

@k-okada k-okada added question and removed MergeOK labels Dec 31, 2021
@sktometometo
Copy link
Contributor Author

I agree with 1 and 2.

@sktometometo sktometometo marked this pull request as draft January 4, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialogflow_task_executive hacktoberfest-accepted https://hacktoberfest.digitalocean.com/hacktoberfest-update question
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants