Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dialogflow_task_executive] load dialogflow project_id from credentials #319

Merged

Conversation

knorth55
Copy link
Member

this PR is split from #313
this PR loads project_id from credential json.
with this PR, we only need to pass json path, no need to pass project id.

@knorth55 knorth55 added dependencies Pull requests that update a dependency file enhancement and removed dependencies Pull requests that update a dependency file labels Dec 31, 2021
@knorth55 knorth55 mentioned this pull request Dec 31, 2021
9 tasks
@k-okada k-okada merged commit cb90545 into jsk-ros-pkg:master Dec 31, 2021
@knorth55 knorth55 deleted the load-dialogflow-project-id-from-json branch December 31, 2021 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants