Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/add switchbot device list publisher #344

Merged

Conversation

sktometometo
Copy link
Contributor

This PR add an device list interface to switchbot_ros.

~/ros/ws_jsk_fetch/src/jsk-ros-pkg/jsk_3rdparty/switchbot_ros $ rostopic echo /switchbot_ros/devices
devices:       
  -
    name: "/eng2/2f/elevator/up/button"
    type: "Bot"     
  -
    name: "/eng2/3f/elevator/up/button"
    type: "Bot"
  -
    name: "/eng2/3f/elevatorhall"
    type: "Hub Mini"
  -
    name: "/eng2/3f/new/autodoor/switch"
    type: "Bot"     
  -
    name: "/eng2/3f/old/autodoor/switch"
    type: "Bot"   
  -
    name: "/eng2/7f/73b2/bot6/button"
    type: "Bot"
  -                                    
    name: "/eng2/7f/73b2/light/lower/switch"
    type: "Bot"
  -                                    
    name: "/eng2/7f/73b2/light/upper/switch"
    type: "Bot"
  -                              
    name: "/eng2/7f/73b2/test/button"
    type: "Bot"
  -                                     
    name: "/eng2/7f/elevator/down/button"
    type: "Bot"
  -                                     
    name: "/eng2/7f/elevatorhall"
    type: "Hub Mini"
  -                                  
    name: "JSK_202012_Bot_5"
    type: "Bot"
  -                                         
    name: "JSK_202012_HubMini_2"
    type: "Hub Mini"
  -                                         
    name: "JSK_202012_HubMini_4"
    type: "Hub Mini"
  -                                  
    name: "Remote"
    type: "Remote"
---                       

switchbot_ros/scripts/switchbot_ros_server.py Outdated Show resolved Hide resolved
switchbot_ros/scripts/switchbot_ros_server.py Outdated Show resolved Hide resolved
switchbot_ros/scripts/switchbot_ros_server.py Outdated Show resolved Hide resolved
switchbot_ros/scripts/switchbot_ros_server.py Outdated Show resolved Hide resolved
switchbot_ros/scripts/switchbot_ros_server.py Outdated Show resolved Hide resolved
@mqcmd196
Copy link
Member

LGTM

@k-okada k-okada merged commit f4f0648 into jsk-ros-pkg:master May 20, 2022
@sktometometo sktometometo deleted the PR/add-switchbot-device-list-publisher branch May 23, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants