Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confirmation on warningp #395

Merged
merged 1 commit into from Nov 1, 2019
Merged

Conversation

Affonso-Gui
Copy link
Member

Apparently we can reproduce the confirmation behavior of the (unused):angle-vector-safe by setting the (even more unused) warningp flag. By doing so, when about to move the real robot a confirmation prompt pops out asking if that is really what we want.

However, when using the warningp this prompt is inverted, so saying that you do NOT want the robot to move make it move:

(send *ri* :warningp t)
(send *ri* :angle-vector (send *pr2* :init-pose) 5000)
Are you sure to move the real robot? (l_arm_controller/follow_joint_trajectory) (YES or NO): no
Are you sure to move the real robot? (r_arm_controller/follow_joint_trajectory) (YES or NO): no
Are you sure to move the real robot? (head_traj_controller/follow_joint_trajectory) (YES or NO): no
Are you sure to move the real robot? (torso_controller/follow_joint_trajectory) (YES or NO): no

;; ROBOT MOVES

@Affonso-Gui
Copy link
Member Author

@k-okada Can I ask for a review?

@k-okada k-okada merged commit 9f48c23 into jsk-ros-pkg:master Nov 1, 2019
@Affonso-Gui Affonso-Gui deleted the fix-warningp branch November 5, 2019 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants