-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pr2eus_tutorials] Fix publish status #464
Conversation
@@ -210,15 +210,15 @@ | |||
(setq *grasp-state* "returning") | |||
(publish-grasp-state) | |||
(pr2-pregrasp-pose) | |||
(publish-info "click tabletop object in Rviz!") | |||
(publish-info "click tabletop object in image_view2!") | |||
(ros::ros-info "click tabletop object in Rviz or in image_view2!") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(defun publish-info (&rest args)
(let ((s (format nil (car args) (cdr args))))
(ros::ros-info s)
(publish-status 'info s)))
publish-info
calls both ros::ros-info
and 'publish-status, so why you need to call
ros::ros-info` twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. (I forgot why I don't use publish-info
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(publish-info "click tabletop object in Rviz!") | ||
(publish-info "click tabletop object in image_view2!") | ||
(ros::ros-info "click tabletop object in Rviz or in image_view2!") | ||
(publish-status 'info (concatenate string "click tabletop object" '(#\newline) "in Rviz or in image_view2!")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be (format nil "click tabletop object~%in Rviz or in image_view2!")
seems simpler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your advice, I improve it.
305c266
to
2017821
Compare
During pr2eus_tutorials, robot status is showed on rviz.
Previously, it only shows "click tabletop object in image_view2! though we can click both on rviz and on image_view2.
So I've changed the showing status
from
to