Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test code for (pr2) and (instance pr2-robot :init) (instance r2-sensor-robot :init) #466

Merged
merged 2 commits into from Nov 19, 2021
Merged

add test code for (pr2) and (instance pr2-robot :init) (instance r2-sensor-robot :init) #466

merged 2 commits into from Nov 19, 2021

Conversation

k-okada
Copy link
Member

@k-okada k-okada commented Nov 17, 2021

follow ups of #426

as jsk-ros-pkg/jsk_robot#1407 (comment) reported, it breaks existing API

Kanazawanaoaki
Kanazawanaoaki approved these changes Nov 19, 2021
View reviewed changes
Copy link

@Kanazawanaoaki Kanazawanaoaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It is backward compatible.

@k-okada k-okada merged commit b2c2429 into jsk-ros-pkg:master Nov 19, 2021
@shmpwk shmpwk mentioned this pull request Dec 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kanazawanaoaki Kanazawanaoaki Kanazawanaoaki approved these changes

Assignees
No one assigned
Labels
PR/MergeOk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@k-okada @Kanazawanaoaki