Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kinfu.h depends on jsk_rviz_plugins #2310

Merged
merged 1 commit into from Nov 1, 2018

Conversation

k-okada
Copy link
Member

@k-okada k-okada commented Jul 27, 2018

if you have jsk_visualization repository in same workspace, it fails as https://gist.github.com/5d108c9845887fbd1b73a940fab03dd2

so we need to add jsk_rviz_plugins to depends.

Cc: @sanketrahul

@sanketrahul
Copy link

@k-okada I downloaded the latest version of the jsk_recognition. The previous error related to jsk_rviz_plugin is fixed now. But I got new error at catkin build posted : https://gist.github.com/sanketrahul/0693b51c8cfbf812346172b030b8f288

@k-okada
Copy link
Member Author

k-okada commented Jul 31, 2018

the error was

$ grep error typescript
[jsk_pcl_ros:make] /home/baxter2/pcl_ros_ws/src/jsk_recognition/jsk_pcl_ros/src/joint_state_static_filter_nodelet.cpp:177:38: error: ‘diagnostic_error_level_’ was not declared in this scope
[jsk_pcl_ros:make]            name_, joint_vital_, stat, diagnostic_error_level_);
[jsk_pcl_ros:make] /home/baxter2/pcl_ros_ws/src/jsk_recognition/jsk_pcl_ros/src/joint_state_static_filter_nodelet.cpp:182:38: error: ‘diagnostic_error_level_’ was not declared in this scope
[jsk_pcl_ros:make]          name_, vital_checker_, stat, diagnostic_error_level_);
[jsk_pcl_ros:make] /home/baxter2/pcl_ros_ws/src/jsk_recognition/jsk_pcl_ros/src/tilt_laser_listener_nodelet.cpp:156:24: error: ‘diagnostic_error_level_’ was not declared in this scope
[jsk_pcl_ros:make]            stat.summary(diagnostic_error_level_,
[jsk_pcl_ros:make] /home/baxter2/pcl_ros_ws/src/jsk_recognition/jsk_pcl_ros/src/tilt_laser_listener_nodelet.cpp:169:38: error: ‘diagnostic_error_level_’ was not declared in this scope
[jsk_pcl_ros:make]          name_, vital_checker_, stat, diagnostic_error_level_);

and #2301 says it recures jsk_topic_tools >= 2.2.7, please run 'sudo apt-get update && sudo apt-get install --reinstall ros-kinetic-jsk-topic-tools'

@sanketrahul
Copy link

Ran the suggested command 'sudo apt-get update && sudo apt-get install --reinstall ros-kinetic-jsk-topic-tools ' by @k-okada got following error saying that OverlayText.h not found https://gist.github.com/sanketrahul/ab971d42699a320e3ef68241ef993e51

@k-okada
Copy link
Member Author

k-okada commented Aug 1, 2018 via email

@k-okada k-okada added this to the 1.2.6 milestone Oct 17, 2018
@k-okada k-okada merged commit 4d879f7 into jsk-ros-pkg:master Nov 1, 2018
@k-okada k-okada deleted the dep_rviz_plugin branch November 1, 2018 07:48
k-okada added a commit to k-okada/jsk_recognition that referenced this pull request Feb 13, 2019
…yText.h, but jsk_recognition should not depends on jsk_visualization, jsk_visualization depends on jsk_recognition
k-okada added a commit to k-okada/jsk_recognition that referenced this pull request Feb 13, 2019
…yText.h, but jsk_recognition should not depends on jsk_visualization, jsk_visualization depends on jsk_recognition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants