[jsk_pcl_ros/cluster_point_indices] Enable use_pca in case of align_boxes is false #2462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
here is a result image.
|
|
thank you , please update document |
iory
changed the title
iory
force-pushed
the
cluster-point-indices-decomposer-use-pca
branch
from
f7373c1
to
483f380
Compare
iory
force-pushed
the
cluster-point-indices-decomposer-use-pca
branch
from
483f380
to
27f87ea
Compare
iory
changed the title
YutoUchimi
requested changes
Nov 1, 2019
|
Thanks for your review! |
YutoUchimi
force-pushed
the
cluster-point-indices-decomposer-use-pca
branch
from
69a8825
to
7509d37
Compare
pazeshun
force-pushed
the
cluster-point-indices-decomposer-use-pca
branch
from
822e255
to
b812d3a
Compare
|
I added axes fixture to avoid random flip around x and y-axis. |
|
I added a comment. Waiting for a @taichiH 's response. |
|
@iory please skip my PR. |
|
I used this node with
|
|
@k-okada can you check and merge this? |
knorth55
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
use_pcain case ofalign_boxesis false.With this PR, we can get the axis of tilted objects and set pose with respect to PCA result to centroid(type:
geometry_msgs::Pose).The video is as follows:
use_pcais Truehttps://drive.google.com/open?id=1UPkxki_pRJ8IEbOwr2cKEbnuP8m52V2A
use_pcais Falsehttps://drive.google.com/open?id=1r3VcoJCHt3NOsyr7Sasy5Wxkvq_SNOAR