New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LabelArray to ssd object detector #2473
Merged
k-okada
merged 10 commits into
jsk-ros-pkg:master
from
Affonso-Gui:add-labelarray-to-ssd-object-detector
Feb 4, 2021
Merged
Add LabelArray to ssd object detector #2473
k-okada
merged 10 commits into
jsk-ros-pkg:master
from
Affonso-Gui:add-labelarray-to-ssd-object-detector
Feb 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iory
approved these changes
Nov 18, 2019
Please update test as well. |
@YutoUchimi Updated. |
YutoUchimi
approved these changes
Nov 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
knorth55
approved these changes
Nov 18, 2019
@k-okada travis passed! can you check and merge this PR? |
@knorth55 @Affonso-Gui please reveiw again, this PR conflicts with current HEAD and I have manually resolved. |
knorth55
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable ssd_object_detector.py to publish LabelArray.
Related to #2467