Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_perception] apply_mask_image publish roi #2476

Merged
merged 2 commits into from Feb 4, 2021

Conversation

kosuke55
Copy link

When camera_info is given, publish camera_info with roi of mask image.

@knorth55
Copy link
Member

BTW, how can you use this camera info?
which node requires this roi values in camera info?
can you paste screen shot of your sample, too?

jsk_perception/src/apply_mask_image.cpp Outdated Show resolved Hide resolved
jsk_perception/src/apply_mask_image.cpp Outdated Show resolved Hide resolved
@kosuke55
Copy link
Author

@knorth55

this is just a question but can we set this variable as true in this case?

I set true without thinking too much. I think It is better to give true or false with rosparam whether to use rectified image as input. How about it?

change name from roi to camera_info.

OK, I will change it.
For reference, attention_clipper also used the name roi.

sensor_msgs::CameraInfo roi(*msg);

@kosuke55
Copy link
Author

@knorth55
In my use case, reflect the detection result in the clipped image to the original image.
I think this is useful when the original image is large and processing is heavy, or when the object is too small to be detected.

clip
Detection result in clipped image

raw
Reflect in the original image

Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for contribution. could you add documentation for this? c.f.https://github.com/jsk-ros-pkg/jsk_recognition/pull/2535/files#diff-9cba1daceb335f6f97bf7980d0d51ec0

@kosuke55 kosuke55 force-pushed the develop branch 3 times, most recently from d802a67 to 9464529 Compare October 11, 2020 07:16
@kosuke55
Copy link
Author

@k-okada k-okada merged commit fcebfb4 into jsk-ros-pkg:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants