Change default value of resolution_factor in DrawRects.cfg #2538
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In draw_rects.cpp, if we use the default value of
resolution_factor
(2.0), the output image size will be twice as large as the input.This resize is done in the following parts:
jsk_recognition/jsk_perception/src/draw_rects.cpp
Lines 159 to 161 in a6abfcc
cv::resize() documentation:
http://opencv.jp/opencv-2svn/cpp/geometric_image_transformations.html#cv-resize
Changing the default values could be disruptive, but I think the current default values are likely to be misleading.