Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default value of resolution_factor in DrawRects.cfg #2538

Merged
merged 2 commits into from Feb 4, 2021

Conversation

708yamaguchi
Copy link
Member

In draw_rects.cpp, if we use the default value of resolution_factor (2.0), the output image size will be twice as large as the input.
This resize is done in the following parts:

cv::resize(cv_img->image, img, cv::Size(),
resolution_factor_, resolution_factor_,
interpolation_method_);

cv::resize() documentation:
http://opencv.jp/opencv-2svn/cpp/geometric_image_transformations.html#cv-resize

Changing the default values could be disruptive, but I think the current default values are likely to be misleading.

@knorth55 knorth55 added the bug label Oct 29, 2020
@knorth55 knorth55 added this to the 1.2.16 milestone Oct 29, 2020
@k-okada k-okada merged commit 2494005 into jsk-ros-pkg:master Feb 4, 2021
@708yamaguchi 708yamaguchi deleted the change-resolution-param branch November 24, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants