Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_perception] Add label_array_to_mask_image #2624

Merged
merged 9 commits into from Sep 9, 2021

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Sep 7, 2021

@iory
I found these commits not merged to master branch from taichiH/master.

I use Useful forks to find these unmerged or non-PR forks.
https://useful-forks.github.io/?repo=jsk-ros-pkg%2Fjsk_recognition

@iory
Copy link
Member

iory commented Sep 7, 2021

That's an awesome function of github! Thanks!

Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, please add documentation @taichiH, @iory

@iory
Copy link
Member

iory commented Sep 7, 2021

I sent a PR to add docs and a test.
knorth55#4
Please check it.

Comment on lines +4 to +5
<arg name="gui" value="false" />
<arg name="queue_size" value="100" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iory

Is it better to set "gpu" arg to -1?

<arg name="gpu" value="-1"/>

It seems test failes becaues there is no gpu environment.
https://github.com/jsk-ros-pkg/jsk_recognition/pull/2624/checks?check_run_id=3532914923#step:5:17104

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your comment!
knorth55#5
I sent a PR to fix this test.

@knorth55 Please check it.

@k-okada
Copy link
Member

k-okada commented Sep 9, 2021

021-09-09T07:13:37.6721772Z Full test results for 'jsk_perception/test_results/jsk_perception/rosunit-test_label_array_to_mask_image.xml'
2021-09-09T07:13:37.6723048Z -------------------------------------------------
2021-09-09T07:13:37.6723892Z <?xml version="1.0" encoding="utf-8"?>
2021-09-09T07:13:37.6724931Z <testsuite errors="0" failures="1" name="unittest.suite.TestSuite" tests="1" time="30.008">
2021-09-09T07:13:37.6726284Z   <testcase classname="__main__.TestTopicPublished" name="test_published" time="30.0077">
2021-09-09T07:13:37.6727659Z     <failure type="AssertionError">Topic [/label_array_to_mask_image/output] is not published
2021-09-09T07:13:37.6728876Z   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
2021-09-09T07:13:37.6729567Z     testMethod()
2021-09-09T07:13:37.6730436Z   File "/opt/ros/indigo/share/jsk_tools/src/test_topic_published.py", line 96, in test_published
2021-09-09T07:13:37.6731353Z     checker.topic_name)
2021-09-09T07:13:37.6732151Z   File "/usr/lib/python2.7/unittest/case.py", line 422, in assertTrue
2021-09-09T07:13:37.6733078Z     raise self.failureException(msg)
2021-09-09T07:13:37.6733748Z     </failure>
2021-09-09T07:13:37.6734256Z   </testcase>
2021-09-09T07:13:37.6735058Z   <system-out><![CDATA[]]></system-out>
2021-09-09T07:13:37.6735969Z   <system-err><![CDATA[]]></system-err>
2021-09-09T07:13:37.6736597Z </testsuite>
2021-09-09T07:13:37.6736916Z 
2021-09-09T07:13:37.6737671Z

still failing?

@iory
Copy link
Member

iory commented Sep 9, 2021

Fixed error.
All required tests passed.

@k-okada k-okada merged commit 1b020c2 into jsk-ros-pkg:master Sep 9, 2021
@knorth55 knorth55 deleted the label-array-to-mask branch September 10, 2021 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants