[jsk_perception/image_publisher.py] Support bgr16, rgb16, bgra16 and rgba16 encodings and compressedDepth for 32FC1 depth image #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was able to get added images and confirmed that 949d29b correctly modified angle field of view to make focal lengths equal for RGBA image. This change is used to check pixel depth conversion of jsk-ros-pkg/jsk_visualization#851 |
|
I send a PR that adds warning for invalid jpeg compression. iory#15
In my opinion, jpeg image don't need to be fixed. Instead we can add another node with a suitable encoding to get compressed image. |
…ion (#15) * [jsk_perception/image_publisher] Use cv2_to_compressed_imgmsg * [jsk_perception/image_publisher] Set compressed image format according to filename
… for 32FC1 depth image
iory
changed the title
[jsk_perception/image_publisher] Fix compressed image format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
In current,
image_publisher.pynot supports bgr16, rgb16, bgra16 and rgba16 encodings and compressedDepth for 32FC1 depth image.This PR enables them to publish.
cc: @nakane11