Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_perception][jsk_pcl_ros_utils][resized_image_transport] Call onInitPostProcess() #2719

Merged
merged 1 commit into from Aug 25, 2022

Conversation

nakane11
Copy link
Member

This node forgets to call onInitPostProcess(), so I added it.

Without calling onInitPostProcess() on onInit() method, nodelet does not subscribe on start even if param always_subscribe is set to true.

@iory
Copy link
Member

iory commented Aug 24, 2022

Are there any other nodelets that are not calling onInitPostProcess than this one?

@nakane11
Copy link
Member Author

#2043 fixed nodelets in jsk_pcl_ros_utils, so I'll check other packages, too.

@nakane11
Copy link
Member Author

Added onInitPostProcess() for all nodelets that use ConnectionBasedNodelet or DiagnosticNodelet and forget to call onInitPostProcess().

@nakane11 nakane11 changed the title [jsk_perception/robot_to_mask_image] Call onInitPostProcess() [jsk_perception][jsk_pcl_ros_utils][resized_image_transport] Call onInitPostProcess() Aug 24, 2022
@nakane11
Copy link
Member Author

$ cd jsk_recognition
$ grep 'DiagnosticNodelet::onInit' -r . -l | xargs grep -L onInitPost | sort
$ grep 'ConnectionBasedNodelet::onInit' -r . -l | xargs grep -L onInitPost | sort
$ grep 'ConnectionBasedNodelet::onInit' -r . -l | xargs grep -L onInitPost | wc
      0       0       0
$ grep 'DiagnosticNodelet::onInit' -r . -l | xargs grep -L onInitPost | wc
      0       0       0

@iory iory self-requested a review August 24, 2022 05:15
@k-okada
Copy link
Member

k-okada commented Aug 24, 2022

@nakane11 please check the following build errors

2022-08-24T06:04:46.0616683Z /usr/include/pcl-1.8/pcl/sample_consensus/model_types.h: In function ?void __static_initialization_and_destruction_0(int, int)?:
2022-08-24T06:04:46.0617649Z /usr/include/pcl-1.8/pcl/sample_consensus/model_types.h:99:3: warning: ?pcl::SAC_SAMPLE_SIZE? is deprecated: This map is deprecated and is kept only to prevent breaking existing user code. Starting from PCL 1.8.0 model sample size is a protected member of the SampleConsensusModel class [-Wdeprecated-declarations]
2022-08-24T06:04:46.0617920Z    SAC_SAMPLE_SIZE (sample_size_pairs, sample_size_pairs + sizeof (sample_size_pairs) / sizeof (SampleSizeModel));
2022-08-24T06:04:46.0618014Z    ^~~~~~~~~~~~~~~
2022-08-24T06:04:46.0618336Z /usr/include/pcl-1.8/pcl/sample_consensus/model_types.h:99:3: note: declared here
2022-08-24T06:04:46.0618706Z /workspace/ros/ws_jsk_recognition/src/jsk_recognition/jsk_perception/src/bounding_box_to_rect.cpp: In member function ?virtual void jsk_perception::BoundingBoxToRect::onInit()?:
2022-08-24T06:04:46.0619038Z /workspace/ros/ws_jsk_recognition/src/jsk_recognition/jsk_perception/src/bounding_box_to_rect.cpp:54:5: error: ?onInitPostPocess? was not declared in this scope
2022-08-24T06:04:46.0619153Z      onInitPostPocess();
2022-08-24T06:04:46.0619251Z      ^~~~~~~~~~~~~~~~
2022-08-24T06:04:46.0619574Z /workspace/ros/ws_jsk_recognition/src/jsk_recognition/jsk_perception/src/bounding_box_to_rect.cpp:54:5: note: suggested alternative: ?onInitPostProcess?
2022-08-24T06:04:46.0619674Z      onInitPostPocess();
2022-08-24T06:04:46.0619762Z      ^~~~~~~~~~~~~~~~
2022-08-24T06:04:46.0619968Z      onInitPostProcess
2022-08-24T06:04:46.0620304Z In file included from /usr/include/pcl-1.8/pcl/sample_consensus/sac_model.h:52:0,
2022-08-24T06:04:46.0620621Z                  from /usr/include/pcl-1.8/pcl/sample_consensus/sac_model_plane.h:44,
2022-08-24T06:04:46.0620959Z                  from /usr/include/pcl-1.8/pcl/segmentation/extract_polygonal_prism_data.h:42,
2022-08-24T06:04:46.0621256Z                  from /workspace/ros/ws_jsk_recognition/src/jsk_recognition/jsk_recognition_utils/include/jsk_recognition_utils/geo/convex_polygon.h:40,
2022-08-24T06:04:46.0621610Z                  from /workspace/ros/ws_jsk_recognition/src/jsk_recognition/jsk_recognition_utils/include/jsk_recognition_utils/geo/cube.h:40,

jsk_perception/src/bounding_box_to_rect.cpp Outdated Show resolved Hide resolved
@k-okada k-okada merged commit d28bf99 into jsk-ros-pkg:master Aug 25, 2022
@nakane11 nakane11 deleted the fix-on-init-process branch August 25, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants