Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsk_pcl_ros] to avoid invalid access, use getGridCoordinates+getCenroidIndexAt function instead of getCentroidIndex. #2748

Merged
merged 2 commits into from Nov 26, 2022
Merged

[jsk_pcl_ros] to avoid invalid access, use getGridCoordinates+getCenroidIndexAt function instead of getCentroidIndex. #2748

merged 2 commits into from Nov 26, 2022

Conversation

iory
Copy link
Member

@iory iory commented Nov 18, 2022

What is this?

To avoid invalid access, use getGridCoordinates + getCenroidIndexAt function instead of getCentroidIndex function.
Without this PR, euclidean_cluster_extraction_nodelet sometimes crashes when ~mutli is True and ~downsample is True.

terminate called after throwing an instance of 'std::out_of_range'
  what():  vector::_M_range_check: __n (which is 0) >= this->size() (which is 0)

@iory
[jsk_pcl_ros] to avoid invalid access, use getGridCoordinates+getCent…
a2a2e22 
…roidIndexAt function instead of getCentroidIndex.
@k-okada k-okada merged commit e8e5ac3 into jsk-ros-pkg:master Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug pkg/jsk_pcl_ros
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iory @k-okada